-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added events past Oct 22, updated officers, updated HoTs, updated members #159
Conversation
Added: - AB Spring Concert - COIN and Bren Joy - AB Speakers - Stephanie Hsu - AB Speakers - Jennette McCurdy - AB Comedy - Melissa Villasenor - UE - Allegheny County Executive Debate - AB Winter Concert - Tiffany Day
Added Clarise Liu and Stella Yim for 23-24
Added information from officer form into officer page. Roles are organized in the order they were announced on Slack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor things! Mainly missing the officer photo assets.
"andrewid": "siyanche", | ||
"img": "siyanche.jpg", | ||
"title": "Co-Finance Chair", | ||
"desc": "I'm Queenie! Junior in Computational Finance minoring in Drama and Behavioral Economics. I love swimming, hiking, participating in theatre (watching/ producing!). Fun fact about me -- my birthday is usually the first/ second day of class for spring semester." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra spaces after the slashes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean dashes (--)? (does that make it the proper long dash thing?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No I mean the first/ second
and watching/ producing
should be first/second
and watching/producing
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though if you want to do that longer dash (em dash or en dash), I usually just Google the character and copy/paste. You could also try —
or –
, but I can't remember if these are sanitized out (so you would need to test that first).
Officer photos from officer form for 23-24. Max photo taken from F22 Classy DS
Delete straw sir :(
Delete gretal.jpg :(
Delete old crliu.jpg :(
Delete old ischang.jpg
Delete sding2 :(
Delete zmansoor :(
Update crew list to match abtech/abtech.org/main
@wjiang42 Let me know when you're ready for another review by clicking the little circle-arrow icon! |
Did I request a review? I clicked some buttons and do not know if they worked |
Added space after -- on line 30
Actual fix for line 30
For real this time line 30 is fixed trust me
"andrewid": "siyanche", | ||
"img": "siyanche.jpg", | ||
"title": "Co-Finance Chair", | ||
"desc": "I'm Queenie! Junior in Computational Finance minoring in Drama and Behavioral Economics. I love swimming, hiking, participating in theatre (watching/ producing!). Fun fact about me -- my birthday is usually the first/ second day of class for spring semester." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No I mean the first/ second
and watching/ producing
should be first/second
and watching/producing
.
"andrewid": "siyanche", | ||
"img": "siyanche.jpg", | ||
"title": "Co-Finance Chair", | ||
"desc": "I'm Queenie! Junior in Computational Finance minoring in Drama and Behavioral Economics. I love swimming, hiking, participating in theatre (watching/ producing!). Fun fact about me -- my birthday is usually the first/ second day of class for spring semester." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though if you want to do that longer dash (em dash or en dash), I usually just Google the character and copy/paste. You could also try —
or –
, but I can't remember if these are sanitized out (so you would need to test that first).
Added: